This repository was archived by the owner on Jan 3, 2026. It is now read-only.
feat!: Do not treat Buffers as JSON by default#621
Merged
danielbankhead merged 35 commits intomainfrom Oct 30, 2024
Merged
Conversation
…o upgrade-node-fetch
|
Warning: This pull request is touching the following templated files:
|
…o do-not-treat-buffer-as-json
…o do-not-treat-buffer-as-json
…o do-not-treat-buffer-as-json
…o do-not-treat-buffer-as-json
`node-fetch` does not yet support webstreams, which is required for `.body` node-fetch/node-fetch#387
Contributor
|
Is there a FR tied to this? |
Contributor
Author
|
@sofisl more-so bug reports and difficult to catch behavior: |
sofisl
suggested changes
Oct 30, 2024
| assert.deepStrictEqual(res.data, {}); | ||
| }); | ||
|
|
||
| it('should set content-type to application/json by default, for buffer', async () => { |
Contributor
There was a problem hiding this comment.
can we write a test that asserts the behavior for what happens if a buffer does get sent in?
Contributor
Author
There was a problem hiding this comment.
Sure, it’s mostly a partial revert of:
but that can be added.
sofisl
approved these changes
Oct 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependency:
node-fetchv3 #617🦕