This repository was archived by the owner on Jan 3, 2026. It is now read-only.
Closed
Conversation
|
Warning: This pull request is touching the following templated files:
|
Contributor
|
Really cool to see and thank you for digging into the numbers, both size wise and speed wise. Seems like there is a lot of work that still needs to happen on the node side for this to be competitive with |
…o do-not-treat-buffer-as-json
…o do-not-treat-buffer-as-json
…o do-not-treat-buffer-as-json
…o do-not-treat-buffer-as-json
`node-fetch` does not yet support webstreams, which is required for `.body` node-fetch/node-fetch#387
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A proof-of-concept for migrating to native
fetch. However, there are a few limitations today.No native
proxysupportIt is possible to enable proxy support, however customers would have to install
unidicidownstream. Including it in this library would make it far too large. Here are some numbers:gaxiosundici@google-cloud/storageAdding
undiciwould double the size of a downstream dependency like@google-cloud/storage.However, there is discussion on adding the
ProxyAgentwithin Node:Workaround
Potential workaround/fallback for customers:
Environment support
Additionally, it wasn't until recently that
undiciadded env support forHTTP_PROXY,HTTPS_PROXY, &NO_PROXYand it will take time for it to propagate to Node.js releases:Performance
The native
fetchimplementation is 26% - 28% slower thannode-fetchaccording toundici's benchmarks:node-fetchReturning Streams
Native
fetchreturns a ReadableStream ('Web Streams') instead ofstream.Readable. While Web Streams have more features, liketeeandcancel, this may require rewriting downstream for many applications that currently expect a Node stream. However, here's a simple way to resolve:In some case we may want to return Web Streams instead - especially if not consumer-facing and to support non-Node.js runtimes/environments.
Additional Notes
https://nodejs.org/en/about/previous-releases
Fixes: googleapis/google-cloud-node-core#165
🦕