This repository was archived by the owner on Jan 3, 2026. It is now read-only.
feat!: Standardize baseURL to URL’s spec#600
Merged
danielbankhead merged 4 commits intomainfrom Oct 29, 2024
Merged
Conversation
- Remove long-deprecated `baseUrl` - Use proper `base` URL logic via `new URL(url, base)`
|
Warning: This pull request is touching the following templated files:
|
baseURLbaseURL to URL’s spec
sofisl
approved these changes
Oct 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notable Changes
baseUrlbaseURL logic vianew URL(url, base)This will align us with the standard way to resolve relative-to-base URLs.
Background: https://developer.mozilla.org/en-US/docs/Web/API/URL_API/Resolving_relative_references
Migration Guide
The expected resolved URL can be determined via:
Example
Resolving to
https://example.com/v1/mango:Notice how the new functionality would allow easy access to
https://example.com/mangoas well by providing{url: '/mango'}(with the leading/).🦕