This repository was archived by the owner on Jan 3, 2026. It is now read-only.
fix: do not override content-type if its given#158
Merged
alexander-fenster merged 2 commits intomasterfrom Aug 26, 2019
Merged
Conversation
bcoe
approved these changes
Aug 26, 2019
bcoe
left a comment
There was a problem hiding this comment.
👍 looks reasonable to me; imagine we'll want to be careful when rolling this out to libraries, but seems like the right change.
Codecov Report
@@ Coverage Diff @@
## master #158 +/- ##
==========================================
+ Coverage 96.55% 96.58% +0.03%
==========================================
Files 4 4
Lines 580 586 +6
Branches 98 100 +2
==========================================
+ Hits 560 566 +6
Misses 19 19
Partials 1 1
Continue to review full report at Codecov.
|
Contributor
Author
|
Let's wait for @JustinBeckwith to release this, just to have one more pair of 👀 checking the logic. |
This was referenced Aug 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #156 by forcing the
Content-Typeheader only it's not set in options. It should work then because the header is set in https://github.com/googleapis/nodejs-googleapis-common/blob/8734154a219c3a2bf865dc830bc95fbb5a640794/src/apirequest.ts#L210 and should be just passed down all the way.