Skip to content

Conversation

@bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Aug 7, 2025

I see two ways to support ClientOptions for ClientOptionsTrait::buildClientOptions:

  1. Call toArray on ClientOptions and keep the logic the same (what we have in this PR)

    • simplest way
    • means that we convert options passed in as ClientOptions to an array and then back again (not so good)
  2. Refactor this class to have a new method which takes ClientOptions, and remove all the backwards compatibility stuff

    • this would be best for the long-run
    • would require a bit more work

TODO: prototype option 2 to see if it's feasible

@bshaffer bshaffer marked this pull request as ready for review September 5, 2025 19:33
@bshaffer bshaffer requested a review from a team September 5, 2025 19:33
@bshaffer bshaffer requested a review from a team as a code owner September 5, 2025 19:33
@bshaffer bshaffer merged commit 68e2336 into main Sep 10, 2025
13 checks passed
@bshaffer bshaffer deleted the support-client-options-in-clientoptionstrait branch September 10, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants