feat: support client options in ClientOptionsTrait::buildClientOptions #621
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see two ways to support
ClientOptionsforClientOptionsTrait::buildClientOptions:Call
toArrayonClientOptionsand keep the logic the same (what we have in this PR)ClientOptionsto an array and then back again (not so good)Refactor this class to have a new method which takes
ClientOptions, and remove all the backwards compatibility stuffTODO: prototype option 2 to see if it's feasible