Skip to content
This repository was archived by the owner on Nov 18, 2025. It is now read-only.

fix: import long in the proto .d.ts files#968

Merged
alexander-fenster merged 2 commits intomasterfrom
import-long
Mar 10, 2021
Merged

fix: import long in the proto .d.ts files#968
alexander-fenster merged 2 commits intomasterfrom
import-long

Conversation

@alexander-fenster
Copy link
Contributor

Fixes googleapis/google-cloud-node-core#376. It works for us because we exclude node_modules in tsconfig.json across all our libraries.

@alexander-fenster alexander-fenster requested a review from bcoe March 10, 2021 17:27
@alexander-fenster alexander-fenster requested a review from a team as a code owner March 10, 2021 17:27
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 10, 2021
@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #968 (a87bf9d) into master (534c59c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     googleapis/gax-nodejs#968   +/-   ##
=======================================
  Coverage   88.58%   88.58%           
=======================================
  Files          43       43           
  Lines        7097     7097           
  Branches      563      612   +49     
=======================================
  Hits         6287     6287           
- Misses        799      800    +1     
+ Partials       11       10    -1     
Impacted Files Coverage Δ
src/fallback.ts 79.24% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 534c59c...b594a04. Read the comment docs.

@alexander-fenster alexander-fenster merged commit 09d7b13 into master Mar 10, 2021
@alexander-fenster alexander-fenster deleted the import-long branch March 10, 2021 22:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

google-gax Cannot find name 'Long'

2 participants