This repository was archived by the owner on Nov 18, 2025. It is now read-only.
feat: set callOptions.retry properties separately#929
Merged
alexander-fenster merged 6 commits intogoogleapis:masterfrom Jan 5, 2021
Merged
feat: set callOptions.retry properties separately#929alexander-fenster merged 6 commits intogoogleapis:masterfrom
alexander-fenster merged 6 commits intogoogleapis:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master googleapis/gax-nodejs#929 +/- ##
==========================================
- Coverage 88.52% 88.52% -0.01%
==========================================
Files 43 43
Lines 7017 7014 -3
Branches 547 601 +54
==========================================
- Hits 6212 6209 -3
Misses 795 795
Partials 10 10
Continue to review full report at Codecov.
|
alexander-fenster
approved these changes
Nov 9, 2020
Contributor
alexander-fenster
left a comment
There was a problem hiding this comment.
LGTM after comments are removed :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes googleapis/google-cloud-node-core#392