Skip to content
This repository was archived by the owner on Nov 18, 2025. It is now read-only.

fix(deps): bump node-fetch to ^2.6.1#900

Merged
JustinBeckwith merged 3 commits intogoogleapis:masterfrom
daggy1234:patch-1
Sep 17, 2020
Merged

fix(deps): bump node-fetch to ^2.6.1#900
JustinBeckwith merged 3 commits intogoogleapis:masterfrom
daggy1234:patch-1

Conversation

@daggy1234
Copy link
Contributor

@daggy1234 daggy1234 commented Sep 14, 2020 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes googleapis/google-cloud-node-core#391 🦕

@daggy1234 daggy1234 requested a review from a team as a code owner September 14, 2020 12:27
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 14, 2020
@codecov
Copy link

codecov bot commented Sep 14, 2020 •
edited
Loading

Codecov Report

Merging #900 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     googleapis/gax-nodejs#900   +/-   ##
=======================================
  Coverage   88.91%   88.91%           
=======================================
  Files          40       40           
  Lines        6513     6513           
  Branches      564      564           
=======================================
  Hits         5791     5791           
  Misses        718      718           
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e57fd9...eb26065. Read the comment docs.

@daggy1234 daggy1234 changed the title Bump node-fetch fix: Bump node-fetch Sep 14, 2020
@JustinBeckwith
Copy link
Contributor

JustinBeckwith commented Sep 17, 2020

@alexander-fenster didn't want to merge this without letting you take a peek :)

@JustinBeckwith JustinBeckwith changed the title fix: Bump node-fetch fix(deps): bump node-fetch to ^2.6.1 Sep 17, 2020
@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 17, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 17, 2020
@JustinBeckwith JustinBeckwith merged commit eacd382 into googleapis:master Sep 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Node Fetch is Vulnerable

3 participants

@daggy1234 @JustinBeckwith @yoshi-kokoro