Skip to content
This repository was archived by the owner on Nov 18, 2025. It is now read-only.

feat: add retryRequestOptions to call settings#879

Merged
AVaksman merged 2 commits intogoogleapis:masterfrom
AVaksman:add_retryRequestOptions
Jul 20, 2020
Merged

feat: add retryRequestOptions to call settings#879
AVaksman merged 2 commits intogoogleapis:masterfrom
AVaksman:add_retryRequestOptions

Conversation

@AVaksman
Copy link
Contributor

@AVaksman AVaksman commented Jul 20, 2020

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes googleapis/google-cloud-node-core#413

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 20, 2020
@codecov
Copy link

codecov bot commented Jul 20, 2020

Codecov Report

Merging #879 into master will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     googleapis/gax-nodejs#879      +/-   ##
==========================================
+ Coverage   88.66%   88.74%   +0.07%     
==========================================
  Files          40       40              
  Lines        6450     6478      +28     
  Branches      512      515       +3     
==========================================
+ Hits         5719     5749      +30     
+ Misses        728      726       -2     
  Partials        3        3              
Impacted Files Coverage Δ
src/gax.ts 96.56% <100.00%> (+0.09%) ⬆️
src/streamingCalls/streaming.ts 94.76% <100.00%> (+1.35%) ⬆️
src/streamingCalls/streamingApiCaller.ts 90.42% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0fbd6a...ae9014a. Read the comment docs.

@AVaksman AVaksman marked this pull request as ready for review July 20, 2020 16:58
@AVaksman AVaksman requested a review from a team as a code owner July 20, 2020 16:58
@AVaksman
Copy link
Contributor Author

Thanks!

@AVaksman AVaksman merged commit aa5487b into googleapis:master Jul 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow setting retry-request options

2 participants