This repository was archived by the owner on Nov 18, 2025. It is now read-only.
chore: document the way to override bundling options#847
Merged
gcf-merge-on-green[bot] merged 2 commits intomasterfrom Jun 4, 2020
Merged
chore: document the way to override bundling options#847gcf-merge-on-green[bot] merged 2 commits intomasterfrom
gcf-merge-on-green[bot] merged 2 commits intomasterfrom
Conversation
alexander-fenster
approved these changes
Jun 4, 2020
Contributor
alexander-fenster
left a comment
There was a problem hiding this comment.
This is OK for documenting on the google-gax side. I think the original issue asks for some extra documentation in @google-cloud/logging, can we add something about redefining bundling to jsdoc there?
Codecov Report
@@ Coverage Diff @@
## master googleapis/gax-nodejs#847 +/- ##
==========================================
- Coverage 89.76% 89.71% -0.05%
==========================================
Files 46 46
Lines 7442 7448 +6
Branches 516 516
==========================================
+ Hits 6680 6682 +2
- Misses 759 763 +4
Partials 3 3
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix googleapis/google-cloud-node-core#479 googleapis/google-cloud-node-core#454