This repository was archived by the owner on Nov 18, 2025. It is now read-only.
fix: fix possible invalid retry variables#682
Merged
xiaozhenliu-gg5 merged 2 commits intomasterfrom Dec 13, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master googleapis/gax-nodejs#682 +/- ##
==========================================
- Coverage 92.09% 92.06% -0.03%
==========================================
Files 39 39
Lines 7324 7324
Branches 404 407 +3
==========================================
- Hits 6745 6743 -2
- Misses 576 578 +2
Partials 3 3
Continue to review full report at Codecov.
|
Contributor
|
I have no idea how this code works, let's talk tomorrow :) |
Contributor
|
Okay now I see how it works, thank you! |
alexander-fenster
approved these changes
Dec 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: googleapis/google-cloud-node-core#431