Skip to content
This repository was archived by the owner on Nov 18, 2025. It is now read-only.

fix(deps): use typescript ~3.6.0#662

Merged
alexander-fenster merged 1 commit intomasterfrom
typescript-3.6
Nov 15, 2019
Merged

fix(deps): use typescript ~3.6.0#662
alexander-fenster merged 1 commit intomasterfrom
typescript-3.6

Conversation

@alexander-fenster
Copy link
Contributor

Fixes googleapis/google-cloud-node-core#421 by reverting TypeScript dependency back to ~3.6.0.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 15, 2019
@codecov
Copy link

codecov bot commented Nov 15, 2019

Codecov Report

Merging #662 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     googleapis/gax-nodejs#662   +/-   ##
=======================================
  Coverage   40.22%   40.22%           
=======================================
  Files          66       66           
  Lines        9127     9127           
  Branches      321      321           
=======================================
  Hits         3671     3671           
  Misses       5363     5363           
  Partials       93       93

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03288ee...5c6f526. Read the comment docs.

@alexander-fenster alexander-fenster merged commit 2a4f255 into master Nov 15, 2019
@alexander-fenster alexander-fenster deleted the typescript-3.6 branch November 15, 2019 21:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1.8.0 breaks our builds with "error TS1086: An accessor cannot be declared in an ambient context."

3 participants