This repository was archived by the owner on Nov 18, 2025. It is now read-only.
feat: reexport protobufjs from gax#544
Merged
alexander-fenster merged 2 commits intomasterfrom Jul 25, 2019
Merged
Conversation
JustinBeckwith
approved these changes
Jul 25, 2019
Contributor
JustinBeckwith
left a comment
There was a problem hiding this comment.
LGTM. I ❤️ the idea of being able to remove almost all explicit dependencies in the gapic generated libraries. We're actually really close.
Codecov Report
@@ Coverage Diff @@
## master #544 +/- ##
=========================================
Coverage ? 89.86%
=========================================
Files ? 52
Lines ? 3512
Branches ? 267
=========================================
Hits ? 3156
Misses ? 290
Partials ? 66
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We sometimes need
protobufjsin client libraries (e.g. for LRO proto loading). gapic-generator does not do a great job detecting ifprotobufjsis needed or not for the given client library, which sometimes causes lint errors about unused dependency.Since
protobufjsis an important part of gax, it will always be installed within gax. Let's just reexport it from gax, so that the client library usedgax.protobuf.loadSync,gax.protobuf.Root, etc. whenever needed. By doing this, we'll removeprotobufjsdependency from the client libraries, and also will make sure there will be no compatibility problems between twoprotobufjsdependencies.