This repository was archived by the owner on Nov 18, 2025. It is now read-only.
fix: routing header parameters must be urlencoded#521
Merged
JustinBeckwith merged 2 commits intomasterfrom Jun 20, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master googleapis/gax-nodejs#521 +/- ##
==========================================
+ Coverage 82.64% 82.65% +0.01%
==========================================
Files 52 52
Lines 3474 3477 +3
Branches 267 267
==========================================
+ Hits 2871 2874 +3
Misses 537 537
Partials 66 66
Continue to review full report at Codecov.
|
JustinBeckwith
approved these changes
Jun 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes googleapis/google-cloud-node-core#430 (cc: @schmidt-sebastian)
Turns out we had our very own implementation of
querystring.stringify. Not anymore.