Skip to content
This repository was archived by the owner on Nov 18, 2025. It is now read-only.

build!: upgrade engines field to >=8.10.0 #483

Merged
JustinBeckwith merged 2 commits into from
May 2, 2019
Merged

build!: upgrade engines field to >=8.10.0 #483

JustinBeckwith merged 2 commits into from
May 2, 2019

Conversation

@bcoe
Copy link

@bcoe bcoe commented May 2, 2019

This drops support for all Node.js versions < 8.10.0, please upgrade

BREAKING CHANGE: library now requires Node >= 8.10.0

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 2, 2019
@codecov
Copy link

codecov bot commented May 2, 2019 •
edited
Loading

Codecov Report

Merging #483 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #483      +/-   ##
==========================================
- Coverage   82.43%   82.36%   -0.08%     
==========================================
  Files          50       50              
  Lines        3439     3419      -20     
  Branches      266      257       -9     
==========================================
- Hits         2835     2816      -19     
  Misses        539      539              
+ Partials       65       64       -1
Impacted Files Coverage Δ
src/index.ts 86.36% <0%> (-4.27%) ⬇️
src/bundlingCalls/bundleExecutor.ts 86.58% <0%> (-0.48%) ⬇️
src/grpc.ts 85.04% <0%> (-0.28%) ⬇️
src/longRunningCalls/longrunning.ts 96.36% <0%> (-0.04%) ⬇️
src/bundlingCalls/task.ts 97.72% <0%> (-0.03%) ⬇️
src/createApiCall.ts 90.47% <0%> (ø) ⬆️
src/streamingCalls/streamingApiCaller.ts 77.77% <0%> (ø) ⬆️
test/utils.ts 92% <0%> (ø) ⬆️
src/descriptor.ts 100% <0%> (ø) ⬆️
test/grpc.ts 92.94% <0%> (ø) ⬆️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6331def...1a68467. Read the comment docs.

@JustinBeckwith JustinBeckwith merged commit 728678a into master May 2, 2019
@JustinBeckwith JustinBeckwith deleted the update-engine-field-2-the-updates-revenge branch May 2, 2019 18:27
@release-please release-please bot mentioned this pull request Mar 17, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bcoe @JustinBeckwith @googlebot