feat: add adhoc debug logger package#1669
Conversation
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
leahecole
left a comment
There was a problem hiding this comment.
I took a quick look and only had really teeny nits about package name agreement
| "fix": "gts fix", | ||
| "prepare": "npm run compile", | ||
| "precompile": "gts clean", | ||
| "samples-test": "echo no samples 🙀", |
There was a problem hiding this comment.
There is a sample, should there either be a test or should this actually say no samples tests?
There was a problem hiding this comment.
@sofisl wanted to add a system test of some kind, so maybe a sample test would be the best place.
I don't have an official sample tag, and I don't know if we even want one, so I made one up as a placeholder. Any thoughts on that?
There was a problem hiding this comment.
For now I'm just "commenting out" the snippet tags. We'll need to revisit that and/or update the typeless bot later to make automatic JS sample updates possible.
sofisl
left a comment
There was a problem hiding this comment.
Generally, LGTM. However, it would be cool to see it in action in a system test, something like gax's showcase-client. But since we haven't added code into our generated libraries I could see this being more of a to-do.
|
Browser tests are failing because I moved them to Node 18. You can wait for this PR to be merged first, or just copy over the .kokoro/**/*browser.cfg/setup/run files from that PR. Or I could admin merge it, since it really doesn't change anything in gax - depends on the speed with which you need it! |
Soon... I can copy over the browser test config, because this will end up being used in some things that want browser support. |
This adds a new pseudo-mono-repo package for adhoc debug logging. It's meant to be pulled in across any library and/or GAPIC to provide the ability to do the equivalent of "printf debugging", but with filtering and a disable flag.
Working group spec doc available upon request :)