Skip to content
This repository was archived by the owner on Nov 18, 2025. It is now read-only.

fix: add dependency to fix tests#1658

Merged
leahecole merged 2 commits intomainfrom
resolve_pdfmake
Sep 24, 2024
Merged

fix: add dependency to fix tests#1658
leahecole merged 2 commits intomainfrom
resolve_pdfmake

Conversation

@leahecole
Copy link
Contributor

@leahecole leahecole commented Sep 23, 2024

Per our discussion in the JS team meeting, add pdfmake as a direct dependency to fix googleapis/google-cloud-node-core#202

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Sep 23, 2024
@leahecole leahecole changed the title fixes #1657 add overrides to fix test issue Sep 23, 2024
@leahecole leahecole marked this pull request as ready for review September 23, 2024 16:46
@leahecole leahecole requested a review from a team as a code owner September 23, 2024 16:46
@leahecole leahecole requested a review from a team September 23, 2024 16:46
Copy link
Member

@viacheslav-rostovtsev viacheslav-rostovtsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leahecole leahecole marked this pull request as draft September 23, 2024 18:25
@leahecole leahecole marked this pull request as ready for review September 23, 2024 18:41
@leahecole leahecole changed the title add overrides to fix test issue fix: add dependency to fix tests Sep 23, 2024
@sofisl
Copy link
Contributor

sofisl commented Sep 23, 2024

Can you add a todo to remove this dependency and compodoc when we move off of it? Ty!

@leahecole
Copy link
Contributor Author

Can you add a todo to remove this dependency and compodoc when we move off of it? Ty!

googleapis/google-cloud-node-core#201 has been added! :)

@leahecole leahecole merged commit 564e9e7 into main Sep 24, 2024
@leahecole leahecole deleted the resolve_pdfmake branch September 24, 2024 13:22
@release-please release-please bot mentioned this pull request Sep 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test failures because of transitive dependency

3 participants