This repository was archived by the owner on Nov 18, 2025. It is now read-only.
fix!: parse from HTTP errors and prefer that as the cannonical error code when it is provided#1633
Merged
sofisl merged 4 commits intogoogleapis:mainfrom Feb 5, 2025
Conversation
…ode when it is provided
Contributor
Author
Contributor
|
@sofisl is it worth also adding a test in the test-application for this? Maybe a modification of the existing |
|
Is there any ETA on this? As described in firebase/firebase-admin-node#2587 (comment), under certain situations the fact the error codes mapping is lossy could be exploited. |
sofisl
approved these changes
Feb 4, 2025
Closed
This was referenced Mar 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes firebase/firebase-admin-node#2587
Fixes googleapis/google-cloud-node-core#206