This repository was archived by the owner on Nov 18, 2025. It is now read-only.
fix: reduce duplicate code, remove old unused dependency#1612
Merged
fix: reduce duplicate code, remove old unused dependency#1612
Conversation
4 tasks
danieljbruce
approved these changes
Jun 6, 2024
Contributor
danieljbruce
left a comment
There was a problem hiding this comment.
This is a great change reducing technical debt. I just suggested some adjustments and potential future work.
sofisl
approved these changes
Jun 6, 2024
sofisl
reviewed
Jun 6, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requestlibrary that wasn't actually being used and was causing security issues for some, fixes Dependencyrequestis missing and vulnerable google-cloud-node-core#217, fixes Missing dependency request causes an error when using Google Cloud's Vision API google-cloud-node-core#212Partially helps with b/342418572