This repository was archived by the owner on Nov 18, 2025. It is now read-only.
Merged
Conversation
- Fix #123: introduces maxResults parameter - Fix #124: fixed the behaviors of the streaming it seems better to be back of using through2.
Codecov Report
@@ Coverage Diff @@
## master googleapis/gax-nodejs#126 +/- ##
=========================================
+ Coverage 92.22% 92.3% +0.08%
=========================================
Files 11 11
Lines 1286 1300 +14
Branches 259 267 +8
=========================================
+ Hits 1186 1200 +14
Misses 100 100
Continue to review full report at Codecov.
|
11 tasks
Contributor
Author
|
friendly ping -- please review this. |
landrito
reviewed
Mar 29, 2017
| }); | ||
| stream.on('resume', function() { | ||
| apiCall(request, options, callback); | ||
| }); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
landrito
approved these changes
Mar 30, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it seems better to be back of using through2.