This repository was archived by the owner on Nov 18, 2025. It is now read-only.
feat: support custom error types in grpc#1759
Merged
miguelvelezsa merged 12 commits intomainfrom May 28, 2025
Merged
Conversation
7da08d5 to
54a2a17
Compare
…known/custom in the errors details.
…d include it in the final details returned.
17bd85b to
9275bb7
Compare
3619ec8 to
a029c69
Compare
sofisl
previously approved these changes
May 23, 2025
sofisl
previously approved these changes
May 28, 2025
sofisl
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Instead of ignoring unknown proto types during
statusDetailsdecoding, this change introduces custom errors wrapped in anAnyproto. This allows clients with knowledge of the specific custom error type to decode it.More information in go/custom-error-details-in-node-rpc.
Impact
Support custom errors instead of ignoring them.
Testing
Added tests here and tested with internal instructions for custom errors.
Checklist