Skip to content
This repository was archived by the owner on Nov 18, 2025. It is now read-only.

feat: support custom error types in grpc#1759

Merged
miguelvelezsa merged 12 commits intomainfrom
feat--support-custom-error-types-in-grpc
May 28, 2025
Merged

feat: support custom error types in grpc#1759
miguelvelezsa merged 12 commits intomainfrom
feat--support-custom-error-types-in-grpc

Conversation

@miguelvelezsa
Copy link
Contributor

Description

Instead of ignoring unknown proto types during statusDetails decoding, this change introduces custom errors wrapped in an Any proto. This allows clients with knowledge of the specific custom error type to decode it.
More information in go/custom-error-details-in-node-rpc.

Impact

Support custom errors instead of ignoring them.

Testing

Added tests here and tested with internal instructions for custom errors.

Checklist

  • [ x] Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • [ x] Ensure the tests and linter pass
  • [ x] Code coverage does not decrease
  • Appropriate docs were updated
  • [ x] Appropriate comments were added, particularly in complex areas or places that require background
  • [ x] No new warnings or issues will be generated from this change

@miguelvelezsa miguelvelezsa requested a review from a team May 21, 2025 18:15
@miguelvelezsa miguelvelezsa requested a review from a team as a code owner May 21, 2025 18:15
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label May 21, 2025
@miguelvelezsa miguelvelezsa force-pushed the feat--support-custom-error-types-in-grpc branch from 7da08d5 to 54a2a17 Compare May 23, 2025 18:04
@miguelvelezsa miguelvelezsa force-pushed the feat--support-custom-error-types-in-grpc branch from 17bd85b to 9275bb7 Compare May 23, 2025 21:09
@miguelvelezsa miguelvelezsa force-pushed the feat--support-custom-error-types-in-grpc branch from 3619ec8 to a029c69 Compare May 23, 2025 21:32
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels May 23, 2025
sofisl
sofisl previously approved these changes May 23, 2025
sofisl
sofisl previously approved these changes May 28, 2025
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels May 28, 2025
@miguelvelezsa miguelvelezsa merged commit 2198283 into main May 28, 2025
28 checks passed
@miguelvelezsa miguelvelezsa deleted the feat--support-custom-error-types-in-grpc branch May 28, 2025 18:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants