Skip to content
This repository was archived by the owner on Nov 18, 2025. It is now read-only.

chore(deps): Remove deprecated dependency @types/long#1738

Merged
sofisl merged 6 commits intogoogleapis:mainfrom
yokotaso:main
Jun 23, 2025
Merged

chore(deps): Remove deprecated dependency @types/long#1738
sofisl merged 6 commits intogoogleapis:mainfrom
yokotaso:main

Conversation

@yokotaso
Copy link
Contributor

@yokotaso yokotaso commented Apr 24, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Description

In my project, I uses @google-analytics/admin.

dependencies like bellow:

npm list long 
├─┬ @google-analytics/admin@8.1.0
│ └─┬ google-gax@5.0.1-rc.0
│   ├─┬ @types/long@5.0.0
│   │ └── long@5.3.2 deduped
│   └─┬ protobufjs@7.5.0
│     └── long@5.3.2 deduped
....

According to @types/long, this package is deprecated.
@types/long itself has no type definition, @types/long is not needed, isn't it?

I got typescript compile error.

> tsc --pretty --noEmit

error TS2688: Cannot find type definition file for 'long'.
 The file is in the program because:
  Entry point for implicit type library 'long'


Found 1 error.

Please provide a detailed description for the change.
As much as possible, please try to keep changes separate by purpose. For example, try not to make a one-line bug fix in a feature request, or add an irrelevant README change to a bug fix.

Impact

What's the impact of this change?

@types/long has no longer any type defenition. so threre would have no impact.

Testing

Have you added unit and integration tests if necessary?
Were any tests changed? Are any breaking changes necessary?

Additional Information

Any additional details that we should be aware of?

Checklist

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease
  • Appropriate docs were updated
  • Appropriate comments were added, particularly in complex areas or places that require background
  • No new warnings or issues will be generated from this change

Fixes #issue_number_goes_here 🦕

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Apr 24, 2025
@yokotaso yokotaso marked this pull request as ready for review April 24, 2025 02:51
@yokotaso yokotaso requested a review from a team April 24, 2025 02:51
@yokotaso yokotaso requested a review from a team as a code owner April 24, 2025 02:51
@heatherhosler
Copy link

The impact is bigger than suggested in this pull request, it would actually enable typescript compilation, which currently throws an error due to @types/long not containing a index.d.ts file and therefore throwing a typescript error. So, at least for me, including gax-nodejs breaks compilation of the whole project.

@malt03
Copy link

malt03 commented Jun 18, 2025

This PR addresses a critical issue that is currently blocking us from upgrading to the latest version of google-gax. The unintended inclusion of @types/long causes TypeScript compilation failures in downstream projects.

It looks like there hasn’t been any activity for about two weeks. Since this is currently blocking us, we’d appreciate it if the PR could be reviewed and merged soon.

Thank you for your attention to this.

$ tsc --noEmit
error TS2688: Cannot find type definition file for 'long'.
  The file is in the program because:
    Entry point for implicit type library 'long'

@sofisl sofisl added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 21, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 21, 2025
@sofisl sofisl merged commit 7ff8181 into googleapis:main Jun 23, 2025
24 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants