This repository was archived by the owner on Nov 18, 2025. It is now read-only.
chore(deps): Remove deprecated dependency @types/long#1738
Merged
sofisl merged 6 commits intogoogleapis:mainfrom Jun 23, 2025
Merged
chore(deps): Remove deprecated dependency @types/long#1738sofisl merged 6 commits intogoogleapis:mainfrom
sofisl merged 6 commits intogoogleapis:mainfrom
Conversation
|
The impact is bigger than suggested in this pull request, it would actually enable typescript compilation, which currently throws an error due to @types/long not containing a |
sofisl
approved these changes
Jun 5, 2025
|
This PR addresses a critical issue that is currently blocking us from upgrading to the latest version of google-gax. The unintended inclusion of @types/long causes TypeScript compilation failures in downstream projects. It looks like there hasn’t been any activity for about two weeks. Since this is currently blocking us, we’d appreciate it if the PR could be reviewed and merged soon. Thank you for your attention to this. |
miguelvelezsa
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In my project, I uses
@google-analytics/admin.dependencies like bellow:
According to @types/long, this package is deprecated.
@types/long itself has no type definition,
@types/longis not needed, isn't it?I got typescript compile error.
Impact
@types/longhas no longer any type defenition. so threre would have no impact.Testing
Additional Information
Checklist
Fixes #issue_number_goes_here 🦕