This repository was archived by the owner on Nov 18, 2025. It is now read-only.
fix!: allow 204 responses in REST fallback mode#1736
Merged
Conversation
3fce153 to
812d7b2
Compare
812d7b2 to
bc5d3d6
Compare
sofisl
previously approved these changes
Jun 6, 2025
sofisl
reviewed
Jun 6, 2025
sofisl
reviewed
Jun 6, 2025
sofisl
reviewed
Jun 6, 2025
sofisl
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has the implementation for allowing 204s in REST fallback
I am not able to add tests to the test application because the Sequence service does not allow us to pass in a sequence of HTTP statuses - only gRPC and in gRPC world, 200 and 204 are both considered success. Additionally, I don't believe I could specify the "error" code of 204 in the Echo service, because 204 isn't an error - it's just empty.
UPDATE: I was able to add tests based on the example given in #1766. When I did a
strictEqualon my example empty response and the response I'm getting from the service, I did seeValues have same structure but are not reference-equal- I chose to compare the JSON stringified versions as one option of comparing, but I'm open to alternatives if we have something that feels a little less janky!Technically a breaking change but only to two APIs, Bigquery and Compute. And, the breakage is that where they would have returned an error for a 2xx and an empty object, now they will return a success (so actually making it work).
I touched two other tests to remove imports that weren't used, but if you want me to take those out, I can!