This repository was archived by the owner on Nov 18, 2025. It is now read-only.
Conversation
|
Warning: This pull request is touching the following templated files:
|
d-goog
reviewed
Feb 13, 2025
| "@grpc/grpc-js": "^1.12.6", | ||
| "@grpc/proto-loader": "^0.7.13", | ||
| "@types/long": "^5.0.0", | ||
| "abort-controller": "^3.0.0", |
Contributor
There was a problem hiding this comment.
This is global in Node 18+; we can drop this dependency in this or separate PR.
Contributor
Author
There was a problem hiding this comment.
Looking through the code, I believe this is only used in browser-contexts.
gax/package.json
Outdated
| "google-auth-library": "^9.3.0", | ||
| "duplexify": "^4.1.3", | ||
| "google-auth-library": "^9.15.1", | ||
| "node-fetch": "^2.7.0", |
Contributor
There was a problem hiding this comment.
We will need this bumped to v3 in order to avoid punycode warnings in Node v22. Here are a few examples:
- DeprecationWarning: The
punycodemodule is deprecated. Please use a userland alternative instead google-auth-library-nodejs#1829 - punycode deprecation warning gaxios#640
Here’s an example migration:
gax/package.json
Outdated
| "protobufjs": "^7.3.2" | ||
| "protobufjs": "^7.4.0", | ||
| "retry-request": "^7.0.2", | ||
| "uuid": "^11.0.5" |
Contributor
There was a problem hiding this comment.
UUID is globally available as of Node 18+. Here’s how we can drop this dependency:
| }, | ||
| "devDependencies": { | ||
| "@types/uuid": "^9.0.7", | ||
| "@babel/plugin-proposal-private-methods": "^7.18.6", |
Contributor
There was a problem hiding this comment.
We should be good to remove this now in Node 18+
gax/src/iamService.ts
Outdated
| // ** This file is automatically generated by gapic-generator-typescript. ** | ||
| // ** https://github.com/googleapis/gapic-generator-typescript ** | ||
| // ** All changes to this file may be overwritten. ** | ||
| /* eslint-disable @typescript-eslint/no-floating-promises */ |
Contributor
There was a problem hiding this comment.
I think these should be handled rather than ignored - even if its adding .catch(console.error).
| "outDir": "build", | ||
| "resolveJsonModule": true, | ||
| "lib": ["ES2018", "DOM"] | ||
| "lib": ["DOM"] |
Contributor
There was a problem hiding this comment.
We may want ES2023 for language support, in case upstream dependencies use newer syntax or features.
Contributor
Author
There was a problem hiding this comment.
We get this for free since it inherits from the top-level config!
| @@ -15,7 +15,7 @@ | |||
| "url": "https://github.com/googleapis/gax-nodejs/issues" | |||
| }, | |||
Contributor
There was a problem hiding this comment.
[Optional] We can use npm workspaces now:
Which has the benefit of enabling top-level tests for all workspaces/packages among other features.
Contributor
Author
There was a problem hiding this comment.
hm good call! Maybe a good process request?
Contributor
|
A quick note, this PR may also close: |
Closed
This was referenced Mar 5, 2025
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Mar 6, 2025
🤖 I have created a release *beep* *boop* --- ## [1.0.0](https://togithub.com/googleapis/gax-nodejs/compare/gapic-tools-v0.4.6...gapic-tools-v1.0.0) (2025-03-05) ### ⚠ BREAKING CHANGES * migrate gax to Node 18 ([#1699](https://togithub.com/googleapis/gax-nodejs/issues/1699)) ### Bug Fixes * bytes field should be typed as a Buffer ([#1652](https://togithub.com/googleapis/gax-nodejs/issues/1652)) ([a81663f](https://togithub.com/googleapis/gax-nodejs/commit/a81663fcdf69a42ee6335c78355b9c8cb11d6064)) * protobuf export path in compileProtos ([#1708](https://togithub.com/googleapis/gax-nodejs/issues/1708)) ([113ca18](https://togithub.com/googleapis/gax-nodejs/commit/113ca18d98f7915c5af05a893d0314744e3d15e1)) ### Miscellaneous Chores * migrate gax to Node 18 ([#1699](https://togithub.com/googleapis/gax-nodejs/issues/1699)) ([fc3eeaa](https://togithub.com/googleapis/gax-nodejs/commit/fc3eeaa574e171c445e0768b06df4ed087bf1f67)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For gax and tools directory: