Skip to content
This repository was archived by the owner on Nov 18, 2025. It is now read-only.

fix: test application cleanup#1639

Merged
leahecole merged 2 commits intomainfrom
cleanup_retries
Aug 6, 2024
Merged

fix: test application cleanup#1639
leahecole merged 2 commits intomainfrom
cleanup_retries

Conversation

@leahecole
Copy link
Contributor

@leahecole leahecole commented Aug 5, 2024

successor to #1636
More test cleanup:

  • removed surrounding promises in retries test and instead threw errors directly - makes it more readable
  • made sure there was proper stream ending and checking for stream end vs. closure where appropriate. The .on('close') check is missing in a couple of spots intentionally and will be added in a subsequent PR that adjusts some stream handoff functionality in retries

@leahecole leahecole requested a review from a team as a code owner August 5, 2024 21:31
@leahecole leahecole requested a review from a team August 5, 2024 21:31
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Aug 5, 2024
@leahecole leahecole merged commit 76ac496 into main Aug 6, 2024
@leahecole leahecole deleted the cleanup_retries branch August 6, 2024 13:44
@release-please release-please bot mentioned this pull request Aug 6, 2024
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@danielbankhead danielbankhead danielbankhead approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@danielbankhead danielbankhead

Labels

size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@leahecole @danielbankhead