Skip to content
This repository was archived by the owner on Nov 18, 2025. It is now read-only.

Commit 61a7143

Browse files
sofislgcf-owl-bot[bot]
sofisl
and
gcf-owl-bot[bot]
authored
feat!: drop Node 12 & decouple development dependencies (#1439)
* feat!: get tools scripts and dependencies running; still need to get top-level module running without tools, remove extra dependencies, and make sure to run commands from the tools dependency * move to node 14 --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
1 parent 8e6888f commit 61a7143

54 files changed

Lines changed: 4323 additions & 80 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.github/sync-repo-settings.yaml‎

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,15 @@ branchProtectionRules:
99
- "ci/kokoro: System test"
1010
- "ci/kokoro: Browser test"
1111
- docs
12-
- lint
13-
- test (12)
14-
- test (14)
15-
- test (16)
12+
- lint-gax
13+
- lint-tools
14+
- test-gax (14)
15+
- test-gax (16)
16+
- test-tools (14)
17+
- test-tools (16)
1618
- cla/google
17-
- windows
19+
- windows-gax
20+
- windows-tools
1821
- OwlBot Post Processor
1922
permissionRules:
2023
- team: yoshi-admins

‎.github/workflows/ci.yaml‎

Lines changed: 45 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@ on:
55
pull_request:
66
name: ci
77
jobs:
8-
test:
8+
test-gax:
99
runs-on: ubuntu-latest
1010
strategy:
1111
matrix:
12-
node: [12, 14, 16]
12+
node: [14, 16]
1313
steps:
1414
- uses: actions/checkout@v3
1515
- uses: actions/setup-node@v3
@@ -26,7 +26,28 @@ jobs:
2626
- run: npm test
2727
env:
2828
MOCHA_THROW_DEPRECATION: false
29-
windows:
29+
test-tools:
30+
runs-on: ubuntu-latest
31+
strategy:
32+
matrix:
33+
node: [14, 16]
34+
steps:
35+
- uses: actions/checkout@v3
36+
- uses: actions/setup-node@v3
37+
with:
38+
node-version: ${{ matrix.node }}
39+
- run: node --version
40+
# The first installation step ensures that all of our production
41+
# dependencies work on the given Node.js version, this helps us find
42+
# dependencies that don't match our engines field:
43+
- run: cd tools; npm install --engine-strict --no-package-lock
44+
# Clean up the production install, before installing dev/production:
45+
- run: cd tools; rm -rf node_modules
46+
- run: cd tools; npm install
47+
- run: cd tools; npm test
48+
env:
49+
MOCHA_THROW_DEPRECATION: false
50+
windows-gax:
3051
runs-on: windows-latest
3152
steps:
3253
- uses: actions/checkout@v3
@@ -37,7 +58,18 @@ jobs:
3758
- run: npm test
3859
env:
3960
MOCHA_THROW_DEPRECATION: false
40-
lint:
61+
windows-tools:
62+
runs-on: windows-latest
63+
steps:
64+
- uses: actions/checkout@v3
65+
- uses: actions/setup-node@v3
66+
with:
67+
node-version: 14
68+
- run: cd tools; npm install
69+
- run: cd tools; npm test
70+
env:
71+
MOCHA_THROW_DEPRECATION: false
72+
lint-gax:
4173
runs-on: ubuntu-latest
4274
steps:
4375
- uses: actions/checkout@v3
@@ -46,6 +78,15 @@ jobs:
4678
node-version: 14
4779
- run: npm install
4880
- run: npm run lint
81+
lint-tools:
82+
runs-on: ubuntu-latest
83+
steps:
84+
- uses: actions/checkout@v3
85+
- uses: actions/setup-node@v3
86+
with:
87+
node-version: 14
88+
- run: cd tools; npm install
89+
- run: cd tools; npm run lint
4990
docs:
5091
runs-on: ubuntu-latest
5192
steps:

‎.kokoro/common.cfg‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎.kokoro/continuous/node12/common.cfg‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.kokoro/continuous/node12/browser-test.cfg renamed to .kokoro/continuous/node14/browser-test.cfg

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎.kokoro/continuous/node14/common.cfg‎

Lines changed: 24 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎.kokoro/continuous/node14/lint.cfg‎

Lines changed: 4 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎.kokoro/continuous/node14/samples-test.cfg‎

Lines changed: 12 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎.kokoro/continuous/node14/system-test.cfg‎

Lines changed: 12 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎.kokoro/continuous/node14/test.cfg‎

Whitespace-only changes.

0 commit comments

Comments
 (0)