Skip to content
This repository was archived by the owner on Sep 26, 2023. It is now read-only.

Splitting GAX into gax + gax-grpc #288

Merged
garrettjonesgoogle merged 5 commits into from
Apr 22, 2017
Merged

Splitting GAX into gax + gax-grpc #288

garrettjonesgoogle merged 5 commits into from
Apr 22, 2017

Conversation

@garrettjonesgoogle
Copy link
Member

@garrettjonesgoogle garrettjonesgoogle commented Apr 20, 2017 •
edited
Loading

Tested:

  • build/test/install
  • license validation
  • google-java-format: there is a problem with this plugin, so I filed an issue to address it later (Fix running of google-java-format in individual modules #287); basically, gax-grpc won't be covered by the plugin for now.
  • updateDocsWithCurrentVersion (using distinct gax/gax-grpc versions)
  • uploadArchives (using distinct gax/gax-grpc versions) (checked in Sonatype)

Note: The version has to be bumped with this commit, otherwise the README will point to a non-existent package.

Still to do

  • make an update in google-cloud-java for these changes

@codecov-io
Copy link

codecov-io commented Apr 21, 2017 •
edited
Loading

Codecov Report

Merging #288 into master will decrease coverage by 2.89%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #288     +/-   ##
===========================================
- Coverage     73.78%   70.88%   -2.9%     
+ Complexity      361      341     -20     
===========================================
  Files            66       68      +2     
  Lines          1812     1817      +5     
  Branches        148      148             
===========================================
- Hits           1337     1288     -49     
- Misses          405      464     +59     
+ Partials         70       65      -5
Impacted Files Coverage Δ Complexity Δ
.../java/com/google/api/gax/grpc/OperationFuture.java 80% <ø> (ø) 16 <0> (?)
...le/api/gax/retrying/ScheduledRetryingExecutor.java 100% <ø> (ø) 3 <0> (?)
...va/com/google/api/gax/grpc/ChannelAndExecutor.java 75% <ø> (ø) 3 <0> (?)
.../java/com/google/api/gax/grpc/ProviderManager.java 0% <ø> (ø) 0 <0> (?)
...om/google/api/gax/grpc/UnaryCallSettingsTyped.java 88.88% <ø> (ø) 3 <0> (?)
...le/api/gax/grpc/InstantiatingExecutorProvider.java 87.5% <ø> (ø) 4 <0> (?)
...ava/com/google/api/gax/grpc/HeaderInterceptor.java 100% <ø> (ø) 3 <0> (?)
...gle/api/gax/grpc/testing/FakeMethodDescriptor.java 50% <ø> (ø) 2 <0> (?)
...java/com/google/api/gax/grpc/BatchingCallable.java 88.88% <ø> (ø) 3 <0> (?)
...ogle/api/gax/grpc/AbstractFixedSizeCollection.java 75% <ø> (ø) 10 <0> (?)
... and 71 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6f1039...184c489. Read the comment docs.

@garrettjonesgoogle garrettjonesgoogle changed the title WIP: Splitting GAX into gax + gax-grpc Splitting GAX into gax + gax-grpc Apr 21, 2017
@garrettjonesgoogle
Copy link
Member Author

garrettjonesgoogle commented Apr 21, 2017

@michaelbausor I'm putting this out for review now even though the google-cloud-java PR isn't ready, so that the completion of the full review can be earlier.

@garrettjonesgoogle garrettjonesgoogle mentioned this pull request Apr 21, 2017
Merged
@michaelbausor
Copy link
Contributor

michaelbausor commented Apr 21, 2017

Initial review looks good to me

@garrettjonesgoogle garrettjonesgoogle mentioned this pull request Apr 21, 2017
Merged
@michaelbausor
Copy link
Contributor

michaelbausor commented Apr 22, 2017

LGTM

@garrettjonesgoogle garrettjonesgoogle merged commit 5e12fb0 into googleapis:master Apr 22, 2017
@garrettjonesgoogle garrettjonesgoogle mentioned this pull request Apr 22, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@michaelbausor michaelbausor Awaiting requested review from michaelbausor

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@garrettjonesgoogle @codecov-io @michaelbausor