This repository was archived by the owner on Sep 26, 2023. It is now read-only.
fix: [Approach 2] Watchdog does not shut down executor on client closing if the executor is provided by ExecutorProvider.#1883
Closed
fix: [Approach 2] Watchdog does not shut down executor on client closing if the executor is provided by ExecutorProvider.#1883
Conversation
…ecutor is provided by ExecutorProvider.
|
Kudos, SonarCloud Quality Gate passed! |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This approach has fewer code changes, but it makes
shouldAutoClosenot the only source of truth for us to decide should we close the Watchdog(and the executor) or not, it is now implicitly decided byshouldAutoCloseandneedExecutorinClientContext. It may cause some confusion if a customer decides to implement their ownWatchdogProvider.