Conversation
|
The sonar workflow isn't being invoked. Neither |
|
Kudos, SonarCloud Quality Gate passed!
|
.github/workflows/sonar.yaml
Outdated
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any | ||
| SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} | ||
| run: ./gradlew build sonarqube --info | ||
| build-maven: |
There was a problem hiding this comment.
Does this mean we now have two Sonar checks? If we feel confident, maybe we can just switch to Maven, this is not like a release job that we want to be more careful.
There was a problem hiding this comment.
It does. I was debating between removing the gradle version and keeping it -- I figured it would be harmless (just email spam) with two sonar jobs.
I'm pretty confident that we can remove the gradle version if we just want to have only one sonar check.
|
Taking a look at this discrepancy: |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Looking at docs/ resources online: Seems like if there are no relevant code changes, sonarqube won't display coverage/ duplication information. Examples |
|
@blakeli0 Can you re-review this when you get a chance? |
The testing for maven migration done in #1829