ci: downsream test for GraalVM native image#1681
Conversation
7bdbdc7 to
23e5585
Compare
|
The failure in 22.1.0 reflects that the current configuration is not compatible with GraalVM 22.1.0. Screenshot
|
|
This is awesome! Thank you. Should we see if #1682 addresses the 22.1.0 issue? |
|
When I excluded ProtobufMessageFeature in 88ce62d, it stopped appearing in the user-provided feature list: It's working. |
|
With bad change to one of the Feature class (60b5f06 ), the check detected the problem correctly: https://github.com/googleapis/gax-java/runs/6430136484?check_suite_focus=true |
| mvn verify install -B -V -ntp -fae \ | ||
| -Dmaven.javadoc.skip=true \ | ||
| -Dgcloud.download.skip=true \ | ||
| -Denforcer.skip=true | ||
| echo "Modification on the shared dependencies BOM:" | ||
| git diff | ||
| echo | ||
|
|
||
| # This reads the JOB_TYPE environmental variable ("test" or "graalvm") | ||
| .kokoro/build.sh |
There was a problem hiding this comment.
@Neenu1995 I think it's ok to replace the mvn verify install ... with .kokoro/build.sh (with JOB_TYPE: test). Do you see anything missed by this replacement?
With JOB_TYPE= test, build.sh runs:
mvn install -B -V -ntp \
-DskipTests=true \
-Dclirr.skip=true \
-Denforcer.skip=true \
-Dmaven.javadoc.skip=true \
-Dgcloud.download.skip=true \
-T 1C
and
mvn test -B -ntp -Dclirr.skip=true -Denforcer.skip=true
There was a problem hiding this comment.
LGTM.
I don't see any missing use cases.
| fail-fast: false | ||
| matrix: | ||
| java: [8] | ||
| java: [11] |
There was a problem hiding this comment.
Now we need JDK 11 to compile the GAX project.
|
@mpeddada1 Added 22.1.0 back to the build. Let's see the effect of your change. |
|
The build with GraalVM 22.1.0 succeeded. (This only uses java-orgpolicy repository) |
| - run: sudo apt-get update -y | ||
| - run: sudo apt-get install libxml2-utils | ||
| - run: .kokoro/downstream-client-library-check.sh ${{matrix.repo}} | ||
| - run: .kokoro/downstream-client-library-check.sh ${{matrix.repo}} test |
There was a problem hiding this comment.
Now downstream-client-library-check.sh takes 2nd argument, JOB_TYPE.
|
132 successful checks, including downstream checks and GraalVM 22.1.0 checks. |
|
Kudos, SonarCloud Quality Gate passed!
|
Adding test for GraalVM feature behavior using java-orgpolicy repository. This java-orgpolicy repository has integration tests that do not require a GCP project.