Skip to content
This repository was archived by the owner on Sep 26, 2023. It is now read-only.

test: fix flaky BatcherImplTest.testThrottlingBlocking() test#1589

Merged
gcf-merge-on-green[bot] merged 4 commits intomainfrom
fix-flake
Jan 6, 2022
Merged

test: fix flaky BatcherImplTest.testThrottlingBlocking() test#1589
gcf-merge-on-green[bot] merged 4 commits intomainfrom
fix-flake

Conversation

@meltsufin
Copy link
Copy Markdown
Member

No description provided.

@meltsufin meltsufin requested review from a team, chanseokoh and vam-google January 6, 2022 04:22
@meltsufin meltsufin added the automerge Merge the pull request once unit tests and other checks pass. label Jan 6, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 671ae3d into main Jan 6, 2022
@gcf-merge-on-green gcf-merge-on-green bot deleted the fix-flake branch January 6, 2022 21:24
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 6, 2022
@chanseokoh
Copy link
Copy Markdown
Contributor

chanseokoh commented Jan 7, 2022

Unfortunately, this doesn't seem to fix the flakyness. It failed again on the main branch for a PR that was filed and merged about an hour ago.

https://github.com/googleapis/gax-java/actions/runs/1669315722

BTW, the method name in this PR title wasn't correct, so I updated it from testThrottlingNonBlocking() to testThrottlingBlocking().

@chanseokoh chanseokoh changed the title test: fix flaky BatcherImplTest.testThrottlingNonBlocking() test test: fix flaky BatcherImplTest.testThrottlingBlocking() test Jan 7, 2022
@meltsufin
Copy link
Copy Markdown
Member Author

Thanks for fixing the title, but this is starting to look like a bug rather than a flake.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants