Skip to content
This repository was archived by the owner on Sep 26, 2023. It is now read-only.
This repository was archived by the owner on Sep 26, 2023. It is now read-only.

ExponentialRetryAlgorithm allow retries when setting maxAttempts w/o setting TotalTimeout #827

@igorbernstein2

Description

@igorbernstein2

When a user configures a client with the following RetrySettings:

RetrySettings.newBuilder().setMaxAttempts(2).build()

Their expectation is that if an rpc fails, then there will be 2 attempts for retries. However, the default value for RetrySettings.getTotalTimeout is 0, which causes the ExponentialRetryAlgorithm to never retry.

Metadata

Metadata

Labels

🚨This issue needs some love.triage meI really want to be triaged.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions