Skip to content
This repository was archived by the owner on Sep 26, 2023. It is now read-only.
This repository was archived by the owner on Sep 26, 2023. It is now read-only.

Watchdog waits on executor shutdown in awaitTermination, even if ExecutorProvider has shouldAutoClose == false #1858

@johnjcasey

Description

@johnjcasey

Environment details

  • Programming language:
  • OS:
  • Language runtime version:
  • Package version: 2.19.2

Steps to reproduce

  1. When using a BigQueryWriteClient with a custom ExecutorProvider
  2. And that executorProvider has shouldAutoClose == false
  3. The watchdog that gets spun up in ClientContext uses this provided executor, but is marked as shouldAutoClose == true (which is correct, because the watchdog has futures that need to be closed)
  4. This results in the watchdog awaiting on executor shutdown when awaitTermination is called

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions