Skip to content
This repository was archived by the owner on Sep 26, 2023. It is now read-only.
This repository was archived by the owner on Sep 26, 2023. It is now read-only.

Fix incomplete javadoc for TracedResponseObserver or change behavior #1261

@igorbernstein2

Description

@igorbernstein2

I accidentally left incomplete javadoc for the TracedResponseObserver class. It was supposed to read

 * <p>The operation will be marked as complete before notifying the wrapped observer. Which means
 * that the span of the instrumentation will not include processing of the innerObserver's
 * onComplete.
 *

However, while trying to remember my intent when writing that class, I'm not sure if this is the desired behavior. My original intention was to try exclude the caller's processing from metrics gathered callable chain below. However looking at it with fresh eyes, I dont think that. possible because there many callbacks of onResponse that will invoke observers callable above. So now it seems arbitrary to exclude onComplete from the span.

I'm not sure if this behavior should be changed or just documented. I would like a second opinion before making the change

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority: p2Moderately-important priority. Fix may not be included in next release.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions