Skip to content
This repository was archived by the owner on Sep 26, 2023. It is now read-only.
This repository was archived by the owner on Sep 26, 2023. It is now read-only.

InstantiatingGrpcChannelProvider requires ScheduledExecutorService for no good reason #1055

@ChuntaoLu

Description

@ChuntaoLu

The InstantiatingGrpcChannelProvider.withExecutor method requires ScheduledExecutorService, and similarly the InstantiatingGrpcChannelProvider$Builder. setExecutorProvider requires a ExecutorProvider(which provides ScheduledExecutorService), but this requirement seems overly strict, because the executor is only used for ManagedChannelBuilder.executor, which takes Executor rather than ScheduledExecutorService.

This unnecessary restriction prevents users from providing a more performant executor (e.g. ForkJoinPool) than ScheduledThreadPoolExecutor when building a gRPC channel.

Metadata

Metadata

Assignees

Labels

priority: p2Moderately-important priority. Fix may not be included in next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions