This repository was archived by the owner on Jan 18, 2026. It is now read-only.
fix: un-blocklist some common package names#827
Merged
alexander-fenster merged 3 commits intomasterfrom Mar 6, 2021
Merged
Conversation
xiaozhenliu-gg5
approved these changes
Mar 5, 2021
bcoe
approved these changes
Mar 5, 2021
This was referenced Mar 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes googleapis/google-cloud-node-core#626. Allows generating
google.iam.v1when it's the only service to be generated (so it will still ignore it when it's coming as a dependency of Pub/Sub or anything else). Also, allowinggoogle.api.*(making sure we only disallowgoogle.apiitself, not its nested packages).Minor refactor included: throw instances of
Errorinstead of just strings.@sofisl This took some time to figure out! Sorry for delay with this fix.