This repository was archived by the owner on Jan 18, 2026. It is now read-only.
refactor: major generated test refactor, gts-2.0-compatible#365
Merged
alexander-fenster merged 1 commit intomasterfrom Mar 27, 2020
Merged
refactor: major generated test refactor, gts-2.0-compatible#365alexander-fenster merged 1 commit intomasterfrom
alexander-fenster merged 1 commit intomasterfrom
Conversation
a938ac9 to
eeb805f
Compare
eeb805f to
f8e8aa2
Compare
JustinBeckwith
approved these changes
Mar 27, 2020
bcoe
approved these changes
Mar 27, 2020
xiaozhenliu-gg5
approved these changes
Mar 27, 2020
Contributor
xiaozhenliu-gg5
left a comment
There was a problem hiding this comment.
Thank you! this is awesome!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes googleapis/google-cloud-node-core#659.
So... this started as an attempt to make the generated tests just a little bit less ugly, but... here we go, complete refactor, 98+% coverage, proper TypeScript import,
async/awaitin tests, and puresinonwith no weird manual mocks.Just one example. Before:
Now:
Benefits of having good test coverage: I fixed 3 or 4 typing issues in the client :)
Sinon rocks.