This repository was archived by the owner on Jan 18, 2026. It is now read-only.
fix: Fix protos import in index files#1498
Merged
sofisl merged 1 commit intogoogleapis:mainfrom Dec 15, 2023
Merged
Conversation
When `import type` is used, it is not possible to use the classes and values in the protos namespace. Fixes #1496
0f5f05b to
b39701f
Compare
Contributor
Author
|
ping |
sofisl
approved these changes
Dec 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
import typeis used, it is not possible to use the classes and values in the protos namespace.Fixes googleapis/google-cloud-node-core#556