Skip to content

chore: fix typos in templated files #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gcf-merge-on-green merged 2 commits into from
Jul 26, 2021
Merged

chore: fix typos in templated files #962

gcf-merge-on-green merged 2 commits into from
Jul 26, 2021

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Jul 25, 2021

No description provided.

@parthea parthea requested a review from a team as a code owner July 25, 2021 14:00
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 25, 2021
@parthea parthea mentioned this pull request Jul 25, 2021
Merged
4 tasks
busunkim96
busunkim96 previously approved these changes Jul 26, 2021
View reviewed changes
@busunkim96
Copy link
Contributor

busunkim96 commented Jul 26, 2021

It looks like there's a diff between the goldens and the templates.

You can use bazel to update the golden files:

bazel run //tests/integration:asset_update
bazel run //tests/integration:credentials_update
bazel run //tests/integration:logging_update
bazel run //tests/integration:redis_update

https://github.com/googleapis/gapic-generator-python/blob/master/DEVELOPMENT.md#integration-tests

@parthea parthea added the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Jul 26, 2021
@gcf-merge-on-green gcf-merge-on-green bot dismissed busunkim96’s stale review July 26, 2021 17:46

This review does not reference the most recent commit, and you are using the secure version of merge-on-green. Please re-review the most recent commit.

@parthea parthea requested a review from busunkim96 July 26, 2021 17:47
@parthea parthea removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Jul 26, 2021
@parthea
Copy link
Contributor Author

parthea commented Jul 26, 2021

@busunkim96 Please can you take another look?

@parthea parthea added the automerge Merge the pull request once unit tests and other checks pass. label Jul 26, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit f6dc5f5 into master Jul 26, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the fix-typos branch July 26, 2021 18:42
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@busunkim96 busunkim96 busunkim96 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@parthea @busunkim96