feat: enable snippetgen for default templates #1171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8bdb709.
software-dov
approved these changes
Feb 2, 2022
Contributor
software-dov
left a comment
There was a problem hiding this comment.
LGTM, one minor nit
gapic/utils/options.py
Outdated
Comment on lines
157
to
158
| if opts.get("old-naming"): | ||
| autogen_snippets = False |
Contributor
There was a problem hiding this comment.
Nit: can you lift the parsing of old_naming to right before here and then just reuse the value?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable snippetgen for the default (non-Ads) templates.
This reverts commit 8bdb709 (which was a revert of #1044 and #1055).
I've checked that the changes are OK (don't break generation for any APIs) by creating a tag and running the presubmit.