-
Notifications
You must be signed in to change notification settings - Fork 77
Closed
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Description
The bazel presubmit for googleapis/googleapis is failing with the latest generator version. See log.
ERROR: /tmpfs/src/piper/google3/third_party/googleapis/google/ads/googleads/v3/BUILD.bazel:255:1: //google/ads/googleads/v3:googleads_py_micro_gapic: `bazel-out/host/bin/external/com_google_protobuf/protoc --experimental_allow_proto3_optional --plugin=protoc-gen-python_gapic=bazel-out/host/bin/external/gapic_generator_python/gapic_plugin --python_gapic_out=bazel-out/k8-fastbuild/bin/google/ads/googleads/v3/googleads_py_micro_gapic.srcjar.zip --python_gapic_opt=old-naming,lazy-import,python-gapic-name=googleads,python-gapic-templates=ads-templates -Igoogle/ads/googleads/v3/common/ad_asset.proto=google/ads/googleads/v3/common/ad_asset.proto -Igoogle/ads/googleads/v3/common/ad_type_infos.proto=google/ads/googleads/v3/common/ad_type_infos.proto -
...
File "/tmpfs/tools/bazel_root/9c17b202d88c490a45ea631b0d45ecee/sandbox/linux-sandbox/3696/execroot/com_google_googleapis/bazel-out/host/bin/external/gapic_generator_python/gapic_plugin.runfiles/gapic_generator_python/gapic/cli/generate_with_pandoc.py", line 9, in <module>
generate.generate()
File "/tmpfs/tools/bazel_root/9c17b202d88c490a45ea631b0d45ecee/sandbox/linux-sandbox/3696/execroot/com_google_googleapis/bazel-out/host/bin/external/gapic_generator_python/gapic_plugin.runfiles/gapic_generator_python_pip_deps_pypi__click_7_1_2/click/core.py", line 829, in __call__
return self.main(*args, **kwargs)
File "/tmpfs/tools/bazel_root/9c17b202d88c490a45ea631b0d45ecee/sandbox/linux-sandbox/3696/execroot/com_google_googleapis/bazel-out/host/bin/external/gapic_generator_python/gapic_plugin.runfiles/gapic_generator_python_pip_deps_pypi__click_7_1_2/click/core.py", line 782, in main
rv = self.invoke(ctx)
File "/tmpfs/tools/bazel_root/9c17b202d88c490a45ea631b0d45ecee/sandbox/linux-sandbox/3696/execroot/com_google_googleapis/bazel-out/host/bin/external/gapic_generator_python/gapic_plugin.runfiles/gapic_generator_python_pip_deps_pypi__click_7_1_2/click/core.py", line 1066, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/tmpfs/tools/bazel_root/9c17b202d88c490a45ea631b0d45ecee/sandbox/linux-sandbox/3696/execroot/com_google_googleapis/bazel-out/host/bin/external/gapic_generator_python/gapic_plugin.runfiles/gapic_generator_python_pip_deps_pypi__click_7_1_2/click/core.py", line 610, in invoke
return callback(*args, **kwargs)
File "/tmpfs/tools/bazel_root/9c17b202d88c490a45ea631b0d45ecee/sandbox/linux-sandbox/3696/execroot/com_google_googleapis/bazel-out/host/bin/external/gapic_generator_python/gapic_plugin.runfiles/gapic_generator_python/gapic/cli/generate.py", line 63, in generate
res = generator.Generator(opts).get_response(api_schema, opts)
File "/tmpfs/tools/bazel_root/9c17b202d88c490a45ea631b0d45ecee/sandbox/linux-sandbox/3696/execroot/com_google_googleapis/bazel-out/host/bin/external/gapic_generator_python/gapic_plugin.runfiles/gapic_generator_python/gapic/generator/generator.py", line 100, in get_response
template_name, api_schema=api_schema, opts=opts)
File "/tmpfs/tools/bazel_root/9c17b202d88c490a45ea631b0d45ecee/sandbox/linux-sandbox/3696/execroot/com_google_googleapis/bazel-out/host/bin/external/gapic_generator_python/gapic_plugin.runfiles/gapic_generator_python/gapic/generator/generator.py", line 247, in _render_template
template_name, api_schema=subpackage, opts=opts
File "/tmpfs/tools/bazel_root/9c17b202d88c490a45ea631b0d45ecee/sandbox/linux-sandbox/3696/execroot/com_google_googleapis/bazel-out/host/bin/external/gapic_generator_python/gapic_plugin.runfiles/gapic_generator_python/gapic/generator/generator.py", line 285, in _render_template
opts=opts,
File "/tmpfs/tools/bazel_root/9c17b202d88c490a45ea631b0d45ecee/sandbox/linux-sandbox/3696/execroot/com_google_googleapis/bazel-out/host/bin/external/gapic_generator_python/gapic_plugin.runfiles/gapic_generator_python/gapic/generator/generator.py", line 312, in _get_file
self._env.get_template(template_name).render(
File "/tmpfs/tools/bazel_root/9c17b202d88c490a45ea631b0d45ecee/sandbox/linux-sandbox/3696/execroot/com_google_googleapis/bazel-out/host/bin/external/gapic_generator_python/gapic_plugin.runfiles/gapic_generator_python_pip_deps_pypi__Jinja2_2_11_2/jinja2/environment.py", line 883, in get_template
return self._load_template(name, self.make_globals(globals))
File "/tmpfs/tools/bazel_root/9c17b202d88c490a45ea631b0d45ecee/sandbox/linux-sandbox/3696/execroot/com_google_googleapis/bazel-out/host/bin/external/gapic_generator_python/gapic_plugin.runfiles/gapic_generator_python_pip_deps_pypi__Jinja2_2_11_2/jinja2/environment.py", line 857, in _load_template
template = self.loader.load(self, name, globals)
File "/tmpfs/tools/bazel_root/9c17b202d88c490a45ea631b0d45ecee/sandbox/linux-sandbox/3696/execroot/com_google_googleapis/bazel-out/host/bin/external/gapic_generator_python/gapic_plugin.runfiles/gapic_generator_python_pip_deps_pypi__Jinja2_2_11_2/jinja2/loaders.py", line 127, in load
code = environment.compile(source, name, filename)
File "/tmpfs/tools/bazel_root/9c17b202d88c490a45ea631b0d45ecee/sandbox/linux-sandbox/3696/execroot/com_google_googleapis/bazel-out/host/bin/external/gapic_generator_python/gapic_plugin.runfiles/gapic_generator_python_pip_deps_pypi__Jinja2_2_11_2/jinja2/environment.py", line 638, in compile
self.handle_exception(source=source_hint)
File "/tmpfs/tools/bazel_root/9c17b202d88c490a45ea631b0d45ecee/sandbox/linux-sandbox/3696/execroot/com_google_googleapis/bazel-out/host/bin/external/gapic_generator_python/gapic_plugin.runfiles/gapic_generator_python_pip_deps_pypi__Jinja2_2_11_2/jinja2/environment.py", line 832, in handle_exception
reraise(*rewrite_traceback_stack(source=source))
File "/tmpfs/tools/bazel_root/9c17b202d88c490a45ea631b0d45ecee/sandbox/linux-sandbox/3696/execroot/com_google_googleapis/bazel-out/host/bin/external/gapic_generator_python/gapic_plugin.runfiles/gapic_generator_python_pip_deps_pypi__Jinja2_2_11_2/jinja2/_compat.py", line 28, in reraise
raise value.with_traceback(tb)
File "/tmpfs/tools/bazel_root/9c17b202d88c490a45ea631b0d45ecee/sandbox/linux-sandbox/3696/execroot/com_google_googleapis/bazel-out/host/bin/external/gapic_generator_python/gapic_plugin.runfiles/gapic_generator_python/gapic/ads-templates/%namespace/%name/%version/%sub/services/%service/transports/base.py.j2", line 123, in template
'{{ service.name }}Transport',
jinja2.exceptions.TemplateSyntaxError: expected token ',', got '{'
--python_gapic_out: protoc-gen-python_gapic: Plugin failed with status code 1.
INFO: Elapsed time: 352.220s, Critical Path: 128.67s
INFO: 3871 processes: 3754 linux-sandbox, 117 worker.
FAILED: Build did NOT complete successfully
FAILED: Build did NOT complete successfully
File is
Line 123 in f7b1164
| '{{ service.name }}Transport', |
Metadata
Metadata
Assignees
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.