Skip to content

support empty strings for routing headers #2273

@daniel-sanche

Description

@daniel-sanche

The bigtable team is requesting that we always pass the app_profile_id header, even if not set. This allows them to verify that each client does support the header, even if it's not being actively used in each request.

Currently, the gapic generator only accepts truthy headers:

        if request.app_profile_id:
            header_params["app_profile_id"] = request.app_profile_id

I think we should change that to if request.app_profile_id is not None, to accept empty string values, as is used when building the proto

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority: p2Moderately-important priority. Fix may not be included in next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions