-
Notifications
You must be signed in to change notification settings - Fork 79
Closed
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.
Description
The bigtable team is requesting that we always pass the app_profile_id header, even if not set. This allows them to verify that each client does support the header, even if it's not being actively used in each request.
Currently, the gapic generator only accepts truthy headers:
if request.app_profile_id:
header_params["app_profile_id"] = request.app_profile_id
I think we should change that to if request.app_profile_id is not None, to accept empty string values, as is used when building the proto
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.