Skip to content

Base transports w/ 'operations_client' have incorrect typing #1028

@tseaver

Description

@tseaver

From mypy:

google/cloud/datastore_admin_v1/services/datastore_admin/transports/grpc_asyncio.py:297: error: Return type "OperationsAsyncClient" of "operations_client" incompatible with return type "OperationsClient" in supertype "DatastoreAdminTransport"

The sync / async operations client types share no common base class (beyond object). The base transport shouldn't declare any typing at all.

Metadata

Metadata

Assignees

Labels

priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions