feat: generic types for OperationResponse and ServerStream #767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3a1f011 to
f04ecd1
Compare
| $phpDocReturnType = PhpDoc::return($returnType); | ||
| $startCall = AST::return($startCall); | ||
| $genericType = match ($method->methodType) { | ||
| MethodDetails::LRO => $method->hasEmptyLroResponse |
Contributor
There was a problem hiding this comment.
nit:
I am not in love with the mixture of match + ternary here 🤔 . But I do see the benefit over using an if statement.
But it is a nit.
Collaborator
Author
There was a problem hiding this comment.
I love it and want it to stay forever
…apis/gapic-generator-php into add-lro-type-to-operationresponse
Hectorhammett
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #766 and see #771
depends on googleapis/gax-php#620