Skip to content

fix(ast): update import generation to cover annotation parameters #1229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gcf-merge-on-green merged 2 commits into from
Jan 26, 2023
Merged

fix(ast): update import generation to cover annotation parameters #1229

gcf-merge-on-green merged 2 commits into from
Jan 26, 2023

Conversation

@emmileaf
Copy link
Contributor

@emmileaf emmileaf commented Jan 9, 2023

This change is cherry-picked from an AST fix made in the spring branch (#1208). It fixes ImportWriter to account for types introduced by annotation parameters, which as enabled in #1012.

@emmileaf emmileaf marked this pull request as ready for review January 9, 2023 15:28
@emmileaf emmileaf requested a review from a team as a code owner January 9, 2023 15:28
@emmileaf emmileaf requested review from blakeli0 and zhumin8 January 9, 2023 15:28
@emmileaf emmileaf mentioned this pull request Jan 9, 2023
Merged
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@blakeli0 blakeli0 added the automerge Merge the pull request once unit tests and other checks pass. label Jan 26, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit bdf12b0 into main Jan 26, 2023
@gcf-merge-on-green gcf-merge-on-green bot deleted the annotation-import-patch branch January 26, 2023 20:52
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 26, 2023
@release-please release-please bot mentioned this pull request Jan 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blakeli0 blakeli0 blakeli0 approved these changes

@diegomarquezp diegomarquezp diegomarquezp approved these changes

@zhumin8 zhumin8 Awaiting requested review from zhumin8

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@emmileaf @blakeli0 @diegomarquezp