Skip to content
This repository was archived by the owner on Jan 21, 2026. It is now read-only.

fix: tracing not working in mongoose 3.3+#1134

Merged
kjin merged 1 commit intogoogleapis:masterfrom
kjin:mongoose-3.3
Oct 4, 2019
Merged

fix: tracing not working in mongoose 3.3+#1134
kjin merged 1 commit intogoogleapis:masterfrom
kjin:mongoose-3.3

Conversation

@kjin
Copy link
Contributor

@kjin kjin commented Oct 3, 2019

Fixes #1123

Note: We aren't officially adding support for the mongodb npm module (tracing might work, but it almost might not), only extending our support for mongoose.

@kjin kjin requested a review from a team October 3, 2019 21:56
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 3, 2019
@codecov
Copy link

codecov bot commented Oct 3, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@259e9f8). Click here to learn what that means.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1134   +/-   ##
=========================================
  Coverage          ?   94.73%           
=========================================
  Files             ?       99           
  Lines             ?     6511           
  Branches          ?      513           
=========================================
  Hits              ?     6168           
  Misses            ?      181           
  Partials          ?      162
Impacted Files Coverage Δ
test/plugins/test-trace-mongoose.ts 100% <ø> (ø)
src/config.ts 100% <ø> (ø)
src/plugins/plugin-mongodb.ts 60% <60%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 259e9f8...db8fd84. Read the comment docs.

@bcoe bcoe changed the title fix: fix tracing not working in mongoose 3.3+ fix: tracing not working in mongoose 3.3+ Oct 4, 2019
@kjin kjin merged commit fe7e925 into googleapis:master Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support mongodb@3.3+

3 participants