This repository was archived by the owner on Jan 21, 2026. It is now read-only.
fix: unpin @types/node and account for new http.request signatures#1120
Merged
kjin merged 1 commit intogoogleapis:masterfrom Sep 30, 2019
Merged
fix: unpin @types/node and account for new http.request signatures#1120kjin merged 1 commit intogoogleapis:masterfrom
kjin merged 1 commit intogoogleapis:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1120 +/- ##
==========================================
+ Coverage 94.97% 94.98% +<.01%
==========================================
Files 98 98
Lines 6451 6461 +10
Branches 500 503 +3
==========================================
+ Hits 6127 6137 +10
Misses 166 166
Partials 158 158
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for a new signature of
http.requestin Node 10.9+. It also unpins@types/node.