Skip to content

Added DismissRecommendation example.#9

Merged
fiboknacky merged 2 commits intomasterfrom
dismiss-recommendation-ex
Dec 19, 2018
Merged

Added DismissRecommendation example.#9
fiboknacky merged 2 commits intomasterfrom
dismiss-recommendation-ex

Conversation

@fiboknacky
Copy link
Member

No description provided.

@fiboknacky fiboknacky force-pushed the dismiss-recommendation-ex branch from 086acc0 to 2e4312d Compare December 17, 2018 11:24
Copy link

@jimper jimper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comment suggestions, otherwise LGTM

@fiboknacky fiboknacky force-pushed the dismiss-recommendation-ex branch from 2e4312d to 04dcfe1 Compare December 18, 2018 06:22
@fiboknacky fiboknacky self-assigned this Dec 18, 2018
class DismissRecommendation
{
const CUSTOMER_ID = 'INSERT_CUSTOMER_ID_HERE';
// Recommendation ID is the last alphanumeric portion of resource name obtained from
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"resource name" -> "the resource name"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Change-Id: Ic2b030a20a2b59fed5655eea1bf8b897f6a249db
Copy link

@jimper jimper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants