Skip to content

update google/gax to 0.38.0#27

Merged
fiboknacky merged 1 commit intogoogleads:masterfrom
mackenziestarr:update-google/gax-0.38.0
Feb 15, 2019
Merged

update google/gax to 0.38.0#27
fiboknacky merged 1 commit intogoogleads:masterfrom
mackenziestarr:update-google/gax-0.38.0

Conversation

@mackenziestarr
Copy link
Contributor

@fiboknacky I have a preliminary branch here to fix #21. The tests pass but I haven't verified the functionality in the wild.

Copy link
Member

@fiboknacky fiboknacky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for contributing!
I've tested sending some requests and they worked.

@fiboknacky fiboknacky merged commit b2b2100 into googleads:master Feb 15, 2019
@mackenziestarr
Copy link
Contributor Author

thanks for the merge @fiboknacky, do you when we can expect to cut a new release on packagist?

@fiboknacky
Copy link
Member

Should be around 20 days.
If you rush, could you use dev:master version for now?

Cheers,
Knack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to use with GCP packages

2 participants