* #25 - USER_PERMISSION_DENIED. The loginCustomerId header is not added by imerenanu · Pull Request #26 · googleads/google-ads-php

imerenanu · 2019-02-13T15:33:16Z

handles login-customer-id in GoogleAdsGapicClientTrait, passes it further to FixedHeaderMiddleware;

…s not added - handles login-customer-id in GoogleAdsGapicClientTrait, passes it further to FixedHeaderMiddleware;

googlebot · 2019-02-13T15:33:21Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

fiboknacky

Thanks for contributing. One minor request.

fiboknacky · 2019-02-13T16:27:06Z

src/Google/Ads/GoogleAds/Lib/GoogleAdsGapicClientTrait.php

-            ]);
+            $headers = [self::$DEVELOPER_TOKEN_KEY => [$this->developerToken]];
+
+            if (!is_null($this->loginCustomerId))


Could you add a brace around this if clause, per PSR-2 standard?

…not added - add a brace around if clause, per PSR-2 standard

imerenanu · 2019-02-14T07:13:24Z

Hi @fiboknacky,

PSR-2 respected.

fiboknacky · 2019-02-14T07:49:57Z

Hi @fiboknacky,

PSR-2 respected.

Thank you. Could you take care of CLA check too?

imerenanu · 2019-02-15T14:25:50Z

Hi @fiboknacky ,

I have submitted CLA agreement.
I did it behalf of Employer, don't know when it going to be active.

fiboknacky · 2019-02-15T15:49:18Z

Hi @fiboknacky ,

I have submitted CLA agreement.
I did it behalf of Employer, don't know when it going to be active.

Could you reply to GoogleBot as "I signed it!"?

imerenanu · 2019-02-18T08:38:18Z

I signed it!

imerenanu · 2019-02-18T08:45:31Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).

The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.

The email used to register you as an authorized contributor must also be attached to your GitHub account.

I signed it!

fiboknacky · 2019-02-18T10:11:02Z

Hi @imerenanu

Is it intentional to close this PR?
I see that you've signed CLA already, so it's ready to be merged.

Knack

imerenanu · 2019-02-18T14:40:23Z

Hi @fiboknacky ,

No, I did it by mistake. Don't know how it happened :)

fiboknacky · 2019-02-18T23:14:47Z

Thanks for confirming.

* googleads#25 - USER_PERMISSION_DENIED. The loginCustomerId header i…

d8544e3

…s not added - handles login-customer-id in GoogleAdsGapicClientTrait, passes it further to FixedHeaderMiddleware;

fiboknacky suggested changes Feb 13, 2019

View reviewed changes

fiboknacky mentioned this pull request Feb 13, 2019

USER_PERMISSION_DENIED. The loginCustomerId header is not added #25

Closed

googleads#25 - USER_PERMISSION_DENIED. The loginCustomerId header is …

fededae

…not added - add a brace around if clause, per PSR-2 standard

fiboknacky approved these changes Feb 14, 2019

View reviewed changes

imerenanu closed this Feb 18, 2019

imerenanu reopened this Feb 18, 2019

fiboknacky merged commit 456181a into googleads:master Feb 18, 2019

dacdv mentioned this pull request Feb 26, 2021

Error occurred during parsing: Fail to push limit. #538

Closed

huyleresonancetech mentioned this pull request Dec 28, 2023

Switching from V13 to V15 & getting error while uploading click conversion #973

Closed

SeriousJ55 mentioned this pull request May 22, 2025

Unexpected wire type #1085

Closed

DidierROY58 mentioned this pull request May 27, 2025

V27.2.0 php8.4 Error: Maximum call stack size \CredentialsWrapper::getAuthorizationHeaderCallback() #1086

Closed

Conversation

imerenanu commented Feb 13, 2019

Uh oh!

googlebot commented Feb 13, 2019

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

fiboknacky left a comment

Choose a reason for hiding this comment

Uh oh!

fiboknacky Feb 13, 2019

Choose a reason for hiding this comment

Uh oh!

imerenanu commented Feb 14, 2019

Uh oh!

fiboknacky commented Feb 14, 2019

Uh oh!

imerenanu commented Feb 15, 2019

Uh oh!

fiboknacky commented Feb 15, 2019

Uh oh!

imerenanu commented Feb 18, 2019

Uh oh!

imerenanu commented Feb 18, 2019

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

fiboknacky commented Feb 18, 2019

Uh oh!

imerenanu commented Feb 18, 2019

Uh oh!

fiboknacky commented Feb 18, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants